fix(document-schema.js): state the annotation fields on the hand-written interfaces - #1208
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Mearman
force-pushed
the
fix/annotation-interfaces
branch
from
September 10, 2026 21:47
12647de to
6ec51fb
Compare
…ten interfaces The origin/interpretation spread reached every zod schema but not the three interfaces of the recursive family that do not derive from their schemas (ContentTableCell, ContentTable, ContentEmbeddedObject). A field added to only one side compiles away silently, the exact drift the interfaces' own comments warn about. A consumer setting origin on a ContentTable literal failed to typecheck against the interface while parsing fine against the schema.
Mearman
force-pushed
the
fix/annotation-interfaces
branch
from
September 11, 2026 02:48
6ec51fb to
2ea23f6
Compare
Contributor
|
🎉 This PR is included in version 7.9.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a defect PR #1204 shipped with: the
origin/interpretationspread reached every zod schema but not the hand-written interfaces of the recursive family (ContentTableCell,ContentTable,ContentEmbeddedObject), which do not derive from their schemas. A consumer settingoriginon aContentTableliteral fails to typecheck against the interface while parsing fine against the schema -- caught by PR #1202's ooxml.js reader wiring (ooxml.jstypecheck: TS2353).Needed before #1202's reader wiring can land on top of current main.